Skip to content

Fix GitHub issue link in support dropdown menu not working in all cases #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 21, 2025
Merged

Fix GitHub issue link in support dropdown menu not working in all cases #1042

merged 5 commits into from
Mar 21, 2025

Conversation

@josh-wong
Copy link
Member

@josh-wong josh-wong commented Mar 21, 2025

Description

This PR fixes an problem where the link to create a GitHub issue in the support dropdown menu wasn't working every time the link was selected.

Related issues and/or PRs

Changes made

  • Applied fixes to ensure consistent GitHub link behavior by stabilizing state updates, preventing unintended navigation, refining click-outside detection, and explicitly handling link clicks to reliably open the correct URLs.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have updated the side navigation as necessary.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@josh-wong
Fix random GitHub issue linking issue
542b663 
On some pages, the GitHub issue link wouldn't open. This commit implements the linking mechanism in a slightly different way.
@josh-wong
Make cosmetic changes to syntax
e34df55
@josh-wong
Change announcement link to absolute
66bb320 
The Docusaurus docs site uses an absolute link, so I think we should follow that as well.
@josh-wong
Merge branch 'main' into feature/fix-github-issue-link
4827be6
@josh-wong
Fix announcement link
7d02e85
@josh-wong josh-wong added the bugfix Fix that resolves bugs label Mar 21, 2025
@josh-wong josh-wong self-assigned this Mar 21, 2025
@josh-wong josh-wong merged commit 6435eb5 into main Mar 21, 2025
1 check passed
@josh-wong josh-wong deleted the feature/fix-github-issue-link branch March 21, 2025 11:52
josh-wong added a commit that referenced this pull request May 14, 2025
@josh-wong
Fix GitHub issue link in support dropdown menu not working in all cas…
ac55977 
…es (#1042)

* Fix random GitHub issue linking issue

On some pages, the GitHub issue link wouldn't open. This commit implements the linking mechanism in a slightly different way.

* Make cosmetic changes to syntax

* Change announcement link to absolute

The Docusaurus docs site uses an absolute link, so I think we should follow that as well.

* Fix announcement link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@josh-wong josh-wong

Labels

bugfix Fix that resolves bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@josh-wong